From: Phillip Wood <phillip.wood123@gmail.com>
Date: Wed, 20 Apr 2022 10:11:09 GMT
Subject: Re: [PATCH v4 30/31] CI: have osx-gcc use gcc, not clang
Message-ID: <52382f7c-5b6a-63b6-2eb2-26c12f31f529@gmail.com>
In-Reply-To: <xmqqh76orx3v.fsf@gitster.g>

On 20/04/2022 09:13, Junio C Hamano wrote:
> Phillip Wood <phillip.wood@talktalk.net> writes:
> 
>> On 18/04/2022 17:29, Ævar Arnfjörð Bjarmason wrote:
>>> Fix a regression in 707d2f2fe86 (CI: use "$runs_on_pool", not
>>> "$jobname" to select packages & config, 2021-11-23). In that commit I
>>> changed CC=gcc from CC=gcc-9, but on OSX the "gcc" in $PATH points to
>>> clang, we need to use gcc-9 instead.
>>
>> As this is fixing a bug in master, perhaps it would be better as a
>> separate patch that can be merged before this series (this series
>> could be rebased on to the fix)
> 
> Yeah, that sounds quite sensible.
> 
> Or perhaps start from 'master', merge this (and other fixes, if
> there are, in this series), merge Dscho's CI updates and then use
> that as an updated base?

It would certainly be nice to get Dscho's updates merged sooner rather 
than later as I think they represent a more significant improvement for 
CI users. There is a complication though in that Dscho's series adds 
github markup to the build output and this series separates the build 
from the tests which means that is not necessary. I think it should be 
easy enough to change Dscho's series so it only uses github markup for 
the tests which is the main improvement and just wait for the build and 
tests to be separated in this series (ideally they'd be a short easy to 
review series that did just that).

Best Wishes

Phillip