From: Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr>
Date: Wed, 17 Jun 2015 23:39:40 GMT
Subject: [PATCH/RFC v4 07/10] send-email: reduce dependancies impact on parse_address_line
Message-ID: <52249185.592562.1434584380271.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <vpqoakejq38.fsf@anie.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes

> > +	my $commentrgx=qr/\((?:[^)]*)\)/;
> > +	my $quotergx=qr/"(?:[^\"\\]|\\.)*"/;
> > +	my $wordrgx=qr/(?:[^]["\s()<>:;@\\,.]|\\.)+/;
> 
> Spaces around = please.
> ...
> > +	foreach my $token (@tokens) {
> > +	    if ($token =~ /^[,;]$/) {
> 
> Here and below: you're indenting with a 4-column offset, it should be 8.

Should have spent more time on the form... Thanks

> The code below is a bit hard to read (I'm neither fluent in Perl nor in
> the RFC ...). A few more comments would help. A few examples below (it's
> up to you to integrate them or not).

Ok, I'll add comments for the hardest parts.