From: Michael Haggerty Date: Sun, 01 Sep 2013 04:09:26 GMT Subject: Re: Re* [PATCH 1/8] remote-bzr: fix export of utf-8 authors Message-ID: <5222BDF6.3080009@alum.mit.edu> In-Reply-To: On 08/29/2013 11:25 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Actually, I think not fixing it inside that 1/8 is good, as there >> are many existing "cmd > file" (and worse, "cmd > file-$x") in these >> test-*.sh scripts. Clean-up is better done as a follow-up patch. >> >> Here are two that I noticed. >> >> -- >8 -- >> Subject: [PATCH 9/8] contrib/remote-helpers: style updates for test scripts > > And here is the second one. > > -- >8 -- > Subject: [PATCH 10/8] remote-helpers: quote variable references in redirection targets > > Even though it is not required by POSIX to double-quote the > redirection target in a variable, our code does so because some > versions of bash issue a warning without the quotes. > > Signed-off-by: Junio C Hamano > --- > contrib/remote-helpers/test-hg-hg-git.sh | 40 ++++++++++++++++---------------- > 1 file changed, 20 insertions(+), 20 deletions(-) > [...] Looks good. Reviewed-by: Michael Haggerty Michael -- Michael Haggerty mhagger@alum.mit.edu http://softwareswirl.blogspot.com/