From: Brad King <brad.king@kitware.com>
Date: Thu, 29 Aug 2013 18:08:51 GMT
Subject: Re: [PATCH/RFC 4/7] refs: factor delete_ref loose ref step into a helper
Message-ID: <521F8E33.4060906@kitware.com>
In-Reply-To: <xmqqppsw5rv8.fsf@gitster.dls.corp.google.com>

On 08/29/2013 01:28 PM, Junio C Hamano wrote:
> Brad King <brad.king@kitware.com> writes:
>> -	if (!(flag & REF_ISPACKED) || flag & REF_ISSYMREF) {
>> +	if (!(type & REF_ISPACKED) || type & REF_ISSYMREF) {
> 
> Hits from "git grep REF_IS" tell me that all users of REF_IS* symbol
> that check if a bit is on in a word does so against "flag" (either a
> variable called "flag", "flags", or a structure member ".flag").
> 
> This change is making things less consistent, not more, I am afraid.

Okay, I removed this part of the change.  It makes the commit
simpler anyway.

-Brad