From: Johannes Sixt <j6t@kdbg.org>
Date: Thu, 22 Aug 2013 10:46:19 GMT
Subject: Re: [RFC PATCHv6 1/2] repack: rewrite the shell script in C
Message-ID: <5215EBFB.1060402@kdbg.org>
In-Reply-To: <52153C01.6040101@googlemail.com>

Am 22.08.2013 00:15, schrieb Stefan Beller:
> On 08/21/2013 10:56 PM, Junio C Hamano wrote:
>> Stefan Beller <stefanbeller@googlemail.com> writes:
>>> +static int delta_base_offset = 1;
>>> +char *packdir;
>>
>> Does this have to be global?
>
> As the path is pretty obvious (get_object_directory() + "/pack"),
> we could however also construct it again in the signal handler.

I would advise against doing that. The recomputation would call malloc(), 
which is not async-signal-safe. (It would not be the first case where we 
call "forbidden" functions from signal handlers, but we need not pile more 
on top of them.)

-- Hannes