From: Stefan Beller Date: Wed, 21 Aug 2013 10:37:59 GMT Subject: Re: [PATCH] repack: rewrite the shell script in C. Message-ID: <52149887.9050601@googlemail.com> In-Reply-To: <20130821082527.GC2802@elie.Belkin> On 08/21/2013 10:25 AM, Jonathan Nieder wrote: >> +static int delta_base_offset = 0; > > The "= 0" is automatic for statics without an initializer. The > prevailing style in git is to leave it out. > > Behavior change: in the script, wasn't the default "true"? > Yes, I was printing out the arguments of shell version and of the C version and tried to match the arguments. I must have missconfigured the test repository where I run these differential tests. Now that I test again, the --delta-base-offset option shows up as default as it is documented. Now fixing the rest of your annotations. Stefan