From: Torsten Bögershausen <tboegi@web.de>
Date: Sat, 20 Jul 2013 12:06:48 GMT
Subject: Re: [PATCH] Fix compilation on OS X.
Message-ID: <51EA7D58.3050800@web.de>
In-Reply-To: <1374306567-16640-1-git-send-email-tsunanet@gmail.com>

On 2013-07-20 09.49, Benoit Sigoure wrote:
> +#ifdef __APPLE__
> +// On OS X libc headers don't define this symbol.
> +extern char **environ;
> +#endif
> +
A more generic approach could be:

In the file "config.mak.uname": Define a variable in the Darwin section like this
NO_EXT_ENVIRON = UnfortunatelyYes

In "Makefile", pick it up, and convert it into a compiler option:
ifdef NO_EXT_ENVIRON
	BASIC_CFLAGS += -DNO_EXT_ENVIRON
endif

And in "git-compat-util.h", add these lines "at a good place":
#ifdef NO_EXT_ENVIRON
extern char **environ;
#endif

This will allow other OS to use the NO_EXT_ENVIRON when needed,.

Thanks for working on this.
/Torsten