From: Torsten Bögershausen <tboegi@web.de>
Date: Tue, 09 Jul 2013 09:53:38 GMT
Subject: Re: [PATCH 2/2] test-lint: detect 'export FOO=bar'
Message-ID: <51DBDDA2.8070304@web.de>
In-Reply-To: <87a9lwgk0e.fsf@linux-k42r.v.cablecom.net>

On 09.07.13 11:28, Thomas Rast wrote:
> Torsten Bögershausen <tboegi@web.de> writes:
> 
>>> +	/^\s*export\s+[^=]*=/ and err '"export FOO=bar" is not portable (please use FOO=bar && export FOO)';
>> I have a slightly tighter reg exp in my tree, but credits should go to Thomas: 
>>
>> /^\s*export\s+\S+=\S+/
> 
> Hmm, is that correct?  I would expect shells that have problems with
> 'export FOO=bar' to also fail on 'export FOO=' (i.e. set to empty string
> and export).
> 
Good point, thanks