From: Torsten Bögershausen <tboegi@web.de>
Date: Wed, 26 Jun 2013 14:19:15 GMT
Subject: Re: [RFC/PATCH 0/1] cygwin: Remove the Win32 l/stat() functions
Message-ID: <51CAF863.4020803@web.de>
In-Reply-To: <7vppv928jx.fsf@alter.siamese.dyndns.org>

On 2013-06-25 23.18, Junio C Hamano wrote:
> Johannes Sixt <j6t@kdbg.org> writes:
> 
>> Some context: This is about a patch by Ramsay that removes the
>> "schizophrenic lstat" hack for Cygwin. Junio, can you please queue that
>> patch in pu?
> 
> Sure.  Thanks.

First of all,
thanks for the work.

Here some "benchmark" results, 
(The test run of the test suite did the same amout of time).

But:
git status -uno in real life takes double the time,
git 1.8.3 compared against "pu with the vanilla l/stat"
   
    1 second ->  2 seconds on linux kernel
0.2 seconds -> 0.4 seconds on git.git 

Do we have any known problems with the current implementation ?
Does speed matter ?

One vote to keep the special cygwin functions.
(And have a look how to improve the core.filemode)

/Torsten