From: Célestin Matte <celestin.matte@ensimag.fr>
Date: Sat, 08 Jun 2013 20:32:37 GMT
Subject: Re: [PATCH v2 16/22] git-remote-mediawiki: Modify strings for a better coding-style
Message-ID: <51B394E5.8040104@ensimag.fr>
In-Reply-To: <CAPig+cT6Qw1w4x95oT7PctMz_HnpU0Vwv5Bh=n-uqZQWJjFnBw@mail.gmail.com>

Le 08/06/2013 02:39, Eric Sunshine a écrit :
> On Fri, Jun 7, 2013 at 5:42 PM, Célestin Matte
> <celestin.matte@ensimag.fr> wrote:
>> - strings which don't need interpolation are single-quoted for more clarity and
>> slight gain of performance
>> - interpolation is preferred over concatenation in many cases, for more clarity
>> - variables are always used with the ${} operator inside strings
>> - strings including double-quotes are written with qq() so that the quotes do
>> not have to be escaped
> 
> Distinct changes could (IMHO) be split into separate patches for easier review.

This commit is a real pain to cut into 3 distinctive ones. Is this
really necessary?
I will do it if it is, of course.


-- 
Célestin Matte