From: Célestin Matte Date: Fri, 07 Jun 2013 20:32:48 GMT Subject: Re: [PATCH 05/18] Turn double-negated expressions into simple expressions Message-ID: <51B24370.3020706@ensimag.fr> In-Reply-To: Le 07/06/2013 22:25, Eric Sunshine a écrit : > If you do choose to be more precise, it should be done as a separate > patch. Each conceptually distinct change should have its own patch. > Doing so makes changes easier to review and (generally) easier to > cherry-pick. For example, in this particular case, "simplify > doubly-negated expressions" is quite conceptually distinct from "emit > more precise diagnostics". (Textually the changes may happen to > overlap, but conceptually they are unrelated.) OK, I will do another patch. -- Célestin Matte