From: Michael Haggerty Date: Sun, 02 Jun 2013 06:12:42 GMT Subject: Re: [PATCH] object.c: Fix a sparse warning Message-ID: <51AAE25A.6080009@alum.mit.edu> In-Reply-To: <51AA3363.8030705@ramsay1.demon.co.uk> On 06/01/2013 07:46 PM, Ramsay Jones wrote: > > Sparse issues an "'object_array_slopbuf' not declared. Should it be > static?" warning. In order to suppress the warning, since this > symbol does not need more than file visibility, we simply add the > static modifier to its declaration. > > Signed-off-by: Ramsay Jones > --- > > Hi Michael, > > If you need to re-roll the patches in your 'mh/reflife' branch, > could you please squash this into the patch corresponding to > commit cbdeb23e ("object_array_entry: fix memory handling of > the name field", 25-05-2013). Ramsay, thanks for fixing this. Junio, it doesn't seem worth spamming the list with a re-roll for this and the other 1-line fixup commit that I already sent. Would you mind either pulling the re-rolled version that I published here: git://github.com/mhagger/git.git branch reflife-v3, 50f7a18ee9ad537a7bf7992d6eb145299a4884b9 or squashing them onto the patch series yourself? Let me know if this is inconvenient. Thanks, Michael -- Michael Haggerty mhagger@alum.mit.edu http://softwareswirl.blogspot.com/