From: Karsten Blees Date: Thu, 30 May 2013 01:13:27 GMT Subject: t0008-ignores failure (was: Git for Windows 1.8.3) Message-ID: <51A6A7B7.4010802@gmail.com> In-Reply-To: Am 25.05.2013 21:16, schrieb Pat Thoyts: > On that note -- with this merge as it now stands I get the following > test failures: > > t0008-ignores.sh 155, 158, 162, 164 These tests fail because they use absolute paths, e.g. "C:/.../global-excludes", which is then translated to "C/.../global-excludes". Can be fixed like so: --- 8< --- --- a/t/t0008-ignores.sh +++ b/t/t0008-ignores.sh @@ -5,7 +5,7 @@ test_description=check-ignore . ./test-lib.sh init_vars () { - global_excludes="$(pwd)/global-excludes" + global_excludes="global-excludes" } enable_global_excludes () { --- However, this raises the question whether colon is such a good choice as separator in 'git-check-ignore --verbose' output. ':' conflicts at least with Windows absolute paths and ADS names, and also with URLs (in case someone finds 'git ls-files --exclude-from=http://git-tricks.foo/special-exclude-file' useful enough to implement :-) I realize colon was chosen to mimic git-check-attr, however, check-attr prints relative paths only (I think?). How about using TAB or '|' instead? AFAICT, these are typically not used in paths or glob patterns. Cheers, Karsten -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.