From: Johannes Sixt <j6t@kdbg.org>
Date: Fri, 17 May 2013 21:29:12 GMT
Subject: Re: [PATCH 2/6] test-lib: refactor $GIT_SKIP_TESTS matching
Message-ID: <5196A128.7070005@kdbg.org>
In-Reply-To: <87sj1lbkvm.fsf@linux-k42r.v.cablecom.net>

Am 17.05.2013 19:02, schrieb Thomas Rast:
> At this point the splitting has already happened in the caller when it
> does the (refactored)
> 
> +	if match_pattern_list $this_test.$test_count $GIT_SKIP_TESTS
> 
> So $@ and "$@" is actually the same thing.

Not in general: If you omit the double-quotes, the individual words
still undergo path name expansion and the result depends on the files
that happen to match patterns given in $GIT_SKIP_TESTS.

This is not a new problem at the call site of the new function, but we
shouldn't duplicate the same problem in the implementation of the function.

-- Hannes