From: Johannes Sixt Date: Fri, 17 May 2013 05:48:33 GMT Subject: Re: [PATCH 2/6] test-lib: refactor $GIT_SKIP_TESTS matching Message-ID: <5195C4B1.3010201@viscovery.net> In-Reply-To: <9b7e6a882a21b7e1734ec6fd90d3cf0208bb68f1.1368736093.git.trast@inf.ethz.ch> Am 5/16/2013 22:50, schrieb Thomas Rast: > +match_pattern_list () { > + arg="$1" > + shift > + test -z "$*" && return 1 > + for pat in $@ You should have double-quotes around $@ here, but then you can just as well abbreviate to for pat and you don't need the 'test -z "$*' check anymore. -- Hannes