From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Mon, 29 Apr 2013 09:04:41 GMT
Subject: Re: [PATCHv2 7/7] git grep: honor textconv by default
Message-ID: <517E37A9.8040609@drmicha.warpmail.net>
In-Reply-To: <vpqk3npctn8.fsf@grenoble-inp.fr>

Matthieu Moy venit, vidit, dixit 26.04.2013 15:23:
> Michael J Gruber <git@drmicha.warpmail.net> writes:
> 
>> BTW, textconv does not have to be slow - just use textconv-cache.
> 
> Right, thanks for reminding me about this, I had forgotten its existance ;-).
> 
>> I'm still looking for a way to at least treat "git grep" and "git show
>> blob" the same way.
> 
> I agree they should be treated similarly.
> 
>> - Implement the --textconv option but leave the default as is. I did
>> that for "git grep" already (just drop 7/7)
> 
> That seems sensible.
> 
>> but it seems to be cumbersome for "git show blob". I have to recheck.
> 
> It should be possible to have a tri-state for the --[no-]textconv
> option: unset, set to true or set to false. But the code sharing between
> log, show and diff might make that non-trivial.

Right now it's a diffopt bit...

Michael