From: Johannes Sixt Date: Wed, 24 Apr 2013 19:12:39 GMT Subject: Re: [PATCH] submodule: fix quoting in relative_path() Message-ID: <51782EA7.8000500@kdbg.org> In-Reply-To: <20130424162850.GU2278@serenity.lan> Am 24.04.2013 18:28, schrieb John Keeping: > On Wed, Apr 24, 2013 at 09:21:38AM -0700, Junio C Hamano wrote: >> J6t meant a patch to remove the entire case...esac and replace it >> with a single liner (target=${target#"$curdir"/}). > > Ah, I missed the "six-liner" part. But that doesn't work because we > break out of the do...while loop when "$target" starts with "$curdir/" > and replacing the case statement will remove that. Yeah, right, _that_ is what I missed ;-) -- Hannes