From: Dusty Phillips Date: Mon, 22 Apr 2013 22:51:28 GMT Subject: Re: [PATCH 01/16] remote-helpers: avoid has_key Message-ID: <5175BEF0.7040509@buchuki.com> In-Reply-To: On 04/22/2013 04:35 PM, Felipe Contreras wrote: > On Mon, Apr 22, 2013 at 5:28 PM, Junio C Hamano wrote: >> Felipe Contreras writes: >> >>> From: Dusty Phillips >>> >>> It is deprecated. >>> >>> [fc: do the same in remote-bzr] >>> >>> Signed-off-by: Felipe Contreras >>> --- >> No sign-off by the author? >> >> It does not matter for something so trivial like this that there is >> no other way to write, but it is a good habit you should encourage >> your contributors to acquire, so that you do not have to waste time >> with "please sign off" when their next contribution that is more >> substantial comes. > He is not a contributor, he sent a few patches, and then immediately > started gitifyhg, I haven't heard a word from him. > > Still, he was the original author, so... Acknowledged that I will not likely be contributing any more patches. I apologize for the lack of signoffs on the pull requests; I wasn't actually aware that they were going into git mainline already. I will state for the record that all patches I submitted to Felipe's github fork of git in November and December, 2012 were authored by me and only me and I submitted them with the understanding and expectation that they would be licensed under the GPL. Dusty