From: Stefano Lattarini Date: Mon, 22 Apr 2013 17:50:02 GMT Subject: Re: [PATCH] zlib: fix compilation failures with Sun C Compilaer Message-ID: <5175784A.5060805@gmail.com> In-Reply-To: <7vfvyipl4f.fsf@alter.siamese.dyndns.org> On 04/22/2013 06:48 PM, Junio C Hamano wrote: > Stefano Lattarini writes: > >> Do this by removing a couple of useless return statements. Without this >> change, compilation with Sun C Compiler 5.9 (SunOS_i386 Patch 124868-15 >> 2010/08/11) fails with the following message: >> >> "zlib.c", line 192: void function cannot return value >> "zlib.c", line 201: void function cannot return value >> cc: acomp failed for zlib.c > > Thanks for catching a recent regression in the mainline before any > tagged release is made out of it. Very much appreciated. > Actually, I tried to build the bleeding-edge git on Solaris to use it myself, rather than to test it ;-) So, thanks to you and all the git contributors for continuously improving the package, thus making it worth to try to build and use the bleeding-edge version. Best regards, Stefano