From: Michael Haggerty Date: Tue, 16 Apr 2013 14:22:37 GMT Subject: Re: [PATCH v3] cherry-pick: make sure all input objects are commits Message-ID: <516D5EAD.4070503@alum.mit.edu> In-Reply-To: <7v61znsj49.fsf@alter.siamese.dyndns.org> On 04/15/2013 09:12 PM, Junio C Hamano wrote: > The paths given to handle_refs() may also have to be copied before > saved, depending on how ref iteration is implemented, details of > which may change as Michael seems to be updating the area again. > I think we let the callback peek ref_entry->name[] which is stable, > so I suspect we are OK. ref_entry->name is stable as long as invalidate_ref_cache() is not called, and I am not even thinking of changing that (partly because I don't have the energy to audit and adjust all of the callers). Michael -- Michael Haggerty mhagger@alum.mit.edu http://softwareswirl.blogspot.com/