From: Sebastian Götte <jaseg@physik.tu-berlin.de>
Date: Sun, 31 Mar 2013 12:27:20 GMT
Subject: Re: [PATCH v5 4/5] merge/pull Check for untrusted good GPG signatures
Message-ID: <51582BA8.90500@physik.tu-berlin.de>
In-Reply-To: <e92b404b-d5e7-489a-90d0-190d1f15177f@email.android.com>

On 03/31/2013 02:16 PM, Thomas Rast wrote:
> "Sebastian Götte" <jaseg@physik.tu-berlin.de> wrote:
> 
>> expecting success: 
>> test_must_fail git merge --ff-only --verify-signatures side-untrusted
>> 2>mergeerror &&
>>        test_i18ngrep "has a good, untrusted GPG signature" mergeerror
>>
>> ==1430== Conditional jump or move depends on uninitialised value(s)
>> ==1430==    at 0x4C26B5C: strchrnul (mc_replace_strmem.c:711)
>> ==1430==    by 0x47B90B: check_commit_signature (commit.c:1057)
>> ==1430==    by 0x444212: cmd_merge (merge.c:1245)
>> ==1430==    by 0x4050E6: handle_internal_command (git.c:281)
>> ==1430==    by 0x40530C: main (git.c:489)
>>
>> Though I also can't see the problem. strchrnul gets passed a char* that
>> is just fine.
> 
> Usually that means that the string *contents* are uninitialized, usually because you scanned past the end of the string...
I checked for that, everything looks fine to me. The pointer should point to a valid, 0-terminated string.