From: Richard Weinberger <richard@nod.at>
Date: Tue, 26 Mar 2013 13:07:44 GMT
Subject: Re: git ate my home directory :-(
Message-ID: <51519DA0.4090201@nod.at>
In-Reply-To: <384BCFE976364F1EA6E56306566D003A@PhilipOakley>

Am 26.03.2013 09:02, schrieb Philip Oakley:
> From: "Junio C Hamano" <gitster@pobox.com>
> Sent: Monday, March 25, 2013 10:06 PM
>> Jonathan Nieder <jrnieder@gmail.com> writes:
>>
>>> Richard Weinberger wrote:
>>>
>>>> In my scripts I'm setting GIT_DIR to use git-fetch and git-reset without changing the
>>>> current working directory all the time.
>>>
>>> Yeah, for historical reasons GIT_WORK_TREE defaults to $(pwd) when
>>> GIT_DIR is explicitly set.
>>
>> And it *WILL* be that way til the end of time.  Unless you are at
>> the top level of your working tree, you are supposed to tell where
>> the top level is with GIT_WORK_TREE when you use GIT_DIR.  Always.
>
> Should this important warning be part of the git(1) documentation on the environment variables (and possibly other places) given the consequences of this case? It wasn't something
> I'd appreciated from a simple reading.

BTW: Can't we change git-clean such that it will not delete any files if GIT_DIR is set and GIT_WORK_TREE is "."?

Thanks,
//richard