From: Elijah Newren <newren@gmail.com>
Date: Thu, 26 Mar 2009 00:06:46 GMT
Subject: Re: [PATCH] fast-export: Avoid dropping files from commits
Message-ID: <51419b2c0903251706n7cfa053eheff542d20ca9a753@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0903252312460.26370@intel-tinevez-2-302>

Hi,

On Wed, Mar 25, 2009 at 4:13 PM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
>> -     if (commit->parents) {
>> +     if (commit->parents &&
>> +         get_object_mark(&commit->parents->item->object) != 0) {
>>               parse_commit(commit->parents->item);
>>               diff_tree_sha1(commit->parents->item->tree->object.sha1,
>>                              commit->tree->object.sha1, "", &rev->diffopt);
>
> I do not understand that change.
>
> A good explanation in the commit message might help this stupid developer.

I resent the patch in another email (sorry for the duplication, but I
don't trust gmail to preserve patches, and responding inline to
comments via git-send-email isn't so great either).  Let me know if
the explanation is missing anything, is too detailed, or is using
incorrect terminology.  In two cases I was sufficiently unsure about
my wording that I provided extra wording to try to make it clear what
I was talking about.

Thanks,
Elijah