From: Manlio Perillo Date: Mon, 11 Mar 2013 17:09:08 GMT Subject: Re: [RFC/PATCH] git-completion.bash: remove bashism to fix ZSH compatibility Message-ID: <513E0FB4.40607@gmail.com> In-Reply-To: <7v38w1c3ms.fsf@alter.siamese.dyndns.org> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 11/03/2013 17:17, Junio C Hamano ha scritto: > Matthieu Moy writes: > >> The function-wide redirection used for __git_ls_files_helper and >> __git_diff_index_helper work only with bash. Using ZSH, trying to >> complete an inexistant directory gave this: >> >> git add no-such-dir/__git_ls_files_helper:cd:2: no such file or directory: no-such-dir/ >> >> Signed-off-by: Matthieu Moy >> --- > > This is not bash-ism but POSIX.1, even though it is not very well > known. I recall commenting on this exact pattern during the review. > Yes, I was plainning to send another patch to fix this (and your other suggestion regarding the CDPATH environment variable, if I remember correctly), but I was busy with other things; sorry. > [...] Regards Manlio -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlE+D7QACgkQscQJ24LbaURBTgCffpMCPjmcsP53/WE/VIQ2FIIc fiIAn3obBJ1yrHVUEmslz32ezvESCZ4G =7nia -----END PGP SIGNATURE-----