From: Phil Hord <hordp@cisco.com>
Date: Mon, 14 Jan 2013 17:50:17 GMT
Subject: Re: [PATCH] rebase --preserve-merges keeps empty merge commits
Message-ID: <50F44559.6040102@cisco.com>
In-Reply-To: <7vwqvfele2.fsf@alter.siamese.dyndns.org>


Junio C Hamano wrote:
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>> Phil Hord <hordp@cisco.com> writes:
>>
>>> Subject: [PATCH] rebase --preserve-merges keeps empty merge commits
>> I would rephrase it as
>>
>>   rebase --preserve-merges: keep empty merge commits
>>
>> we usually give orders in commit messages, not state facts (it's not
>> clear from the existing subject line whether keeping merge commit is the
>> new behavior or a bug that the commit tries to fix).
> Thanks for giving a concise rationale on our use of imperative mood.
>
> Phil, I think you meant to and forgot to sign-off; here is what I'll
> queue.
>
> Thanks.
>

Looks good.  Thanks for the help.

Phil