From: René Scharfe Date: Sun, 06 Jan 2013 21:59:16 GMT Subject: Re: [PATCH 2/4] t0024, t5000: use test_lazy_prereq for UNZIP Message-ID: <50E9F3B4.2080103@lsrfire.ath.cx> In-Reply-To: <20130106180621.GA16494@ftbfs.org> Am 06.01.2013 19:06, schrieb Matt Kraai: > On Sun, Jan 06, 2013 at 06:49:00PM +0100, René Scharfe wrote: >> This change makes the code smaller and we can put it at the top of >> the script, its rightful place as setup code. > > Would it be better to add the setting of GIT_UNZIP and > test_lazy_prereq to test-lib.sh so they aren't duplicated in both > t0024-crlf-archive.sh and t5000-tar-tree.sh, something like the > following (modulo UNZIP/GIT_UNZIP)? We could do that in a follow-up patch, but I'm not sure it's worth it for the two use cases. René