From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Tue, 13 Nov 2012 19:14:39 GMT
Subject: Re: [PATCH nd/wildmatch] Correct Git's version of isprint and isspace
Message-ID: <50A29C1F.6000006@lsrfire.ath.cx>
In-Reply-To: <1352803572-14547-1-git-send-email-pclouds@gmail.com>

Am 13.11.2012 11:46, schrieb Nguyễn Thái Ngọc Duy:
> Git's isprint includes
> control space characters (10-13). According to glibc-2.14.1 on C
> locale on Linux, this is wrong. This patch fixes it.

isprint() is not in master, yet.  Can we perhaps still introduce it in 
such a way that we never have an incorrect version in master's history?

And could you please update test-ctype.c to match the change to 
isspace()?  The tests there just documented the status quo before I made 
changes to ctype.c long ago, so it's definitions are just as correct (or 
wrong) as the original implementation.

Thanks,
René