From: Johannes Sixt <j6t@kdbg.org>
Date: Mon, 22 Oct 2012 20:04:50 GMT
Subject: Re: [PATCH v3 6/8] longest_ancestor_length(): require prefix list entries to be normalized
Message-ID: <5085A6E2.3060807@kdbg.org>
In-Reply-To: <1350799057-13846-7-git-send-email-mhagger@alum.mit.edu>

Am 21.10.2012 07:57, schrieb Michael Haggerty:
> Move the responsibility for normalizing the prefixes passed to
> longest_ancestor_length() to its caller.  In t0060, only test
> longest_ancestor_lengths using normalized paths: remove empty entries
> and non-absolute paths, strip trailing slashes from the paths, and
> remove tests that thereby become redundant.

t0060 does not pass on Windows with this change. Bash's path mangling
strikes again, but the real reason for the failure is that
test-path-util does not normalize its input before it calls into
longest_ancestor_length(). It is not sufficient to reduce the test cases
to normalized ones, because due to path mangling on Windows they are
turned into unnormalized paths (with backslashes instead of forward
slashes).

I suggest to export the new normalize_ceiling_entry() and use it from
test-path-util. Then don't change or remove existing tests.

-- Hannes