From: Johannes Sixt <j.sixt@viscovery.net>
Date: Tue, 16 Oct 2012 06:39:06 GMT
Subject: Re: [PATCH v2 2/2] grep: stop looking at random places for .gitattributes
Message-ID: <507D010A.8000904@viscovery.net>
In-Reply-To: <7vfw5fy8tx.fsf@alter.siamese.dyndns.org>

Am 10/15/2012 18:54, schrieb Junio C Hamano:
> Ideally, that earlier workaround
> should have done a logica equivalent of:
> ...
> and did so not in-line at the calling site but in a compat/ wrapper
> for fflush() to eliminate the need for the ifdef.

Fair enough.

>> But reverting the EINVAL check from write_or_die.c is out of question,
>> because that handles a real case.

Correction: I can't reproduce the error messages that this was working
around anymore in a brief test. I'll revert the check locally and see what
happens.

-- Hannes