From: René Scharfe Date: Sun, 14 Oct 2012 13:59:31 GMT Subject: Re: [PATCH v5 02/12] ctype: support iscntrl, ispunct, isxdigit and isprint Message-ID: <507AC543.2020402@lsrfire.ath.cx> In-Reply-To: Am 14.10.2012 15:25, schrieb Nguyen Thai Ngoc Duy: > On Sun, Oct 14, 2012 at 7:59 PM, René Scharfe > wrote: >> With that, couldn't you squeeze the other two classes into the existing >> sane_type? > > No there are still conflicts: 9, 10 and 13 as spaces (vs controls) and > 123, 124 and 126 as regex/pathspec special (vs punctuation). That's not a problem, an entry in the table can have more than one bit set -- just OR them together in ctype.c. It may not look as nice, but that's OK. You could also define a character for GIT_SPACE | GIT_CNTRL etc. for cosmetic reasons. René