From: Peter Oberndorfer <kumbayo84@arcor.de>
Date: Tue, 18 Sep 2012 18:23:49 GMT
Subject: Re: [PATCH] gitk: Synchronize highlighting in file view when scrolling diff
Message-ID: <5058BC35.6050007@arcor.de>
In-Reply-To: <1347947874-38597-1-git-send-email-stefan@haller-berlin.de>

On 2012-09-18 07:57, Stefan Haller wrote:
> Whenever the diff pane scrolls, highlight the corresponding file in the
> file list on the right. For a large commit with many files and long
> per-file diffs, this makes it easier to keep track of what you're looking
> at.

Hi,
i like this function!
I have often lost track which file i am currently looking at.
Especially with long files.

But i noticed following minor thing:
When selecting a new commit, for a split second the first file name is selected
and then the "Comments" entry is selected.
The flickering is more visible when you hold down the mouse on the up/down button
of the "Lines of code" field.

Can this flickering be avoided?

Thanks,
Greetings Peter

> This allows simplifying the prevfile and nextfile functions, because
> all they have to do is scroll the diff pane.
>
> Signed-off-by: Stefan Haller <stefan@haller-berlin.de>
> ---
>   gitk | 27 ++++++++++++++++-----------
>   1 file changed, 16 insertions(+), 11 deletions(-)
>
>