From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Wed, 05 Sep 2012 19:36:32 GMT
Subject: Re: git archive --format zip utf-8 issues
Message-ID: <5047A9C0.9020200@lsrfire.ath.cx>
In-Reply-To: <7vehmh8prt.fsf@alter.siamese.dyndns.org>

Am 04.09.2012 23:03, schrieb Junio C Hamano:
> René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
>> +	if (has_non_ascii(path)) {
>
> Do we want to treat \033 as "ascii" in this codepath?  The function
> primarily is used by the log formatter to see if we need 8-bit CTE
> when writing out in the e-mail format.

Argh, yes, I'd think so. The function name mislead me.  This won't 
matter for compatibility testing, but should be corrected before inclusion.

Just checked: unzip strips the ESC character when extracting (whether 
the UTF-8 flag is set or not) and 7-Zip replaces it with an underscore. 
The built-in ZIP extractor of Windows 7 skips such a file; it doesn't 
even show up in archive directory listings.

René