From: Ramsay Jones Date: Thu, 30 Aug 2012 17:25:42 GMT Subject: Re: [PATCH 1/3] remote-testsvn.c: Avoid the getline() GNU extension function Message-ID: <503FA216.8070704@ramsay1.demon.co.uk> In-Reply-To: <7v3939wofb.fsf@alter.siamese.dyndns.org> Junio C Hamano wrote: > Erik Faye-Lund writes: > >> On Sat, Aug 25, 2012 at 7:13 PM, Ramsay Jones >> wrote: >>> >>> The getline() function is a GNU extension (you need to define >>> _GNU_SOURCE before including stdio.h) and is, therefore, not >>> portable. In particular, getline() is not available on MinGW. >> >> Actually, getline is a POSIX-2008 feature, so it's not (simply) a GNU extension: >> >> http://pubs.opengroup.org/onlinepubs/9699919799/functions/getline.html > > True, thanks for pointing it out. Justify the change with something > like this instead, perhaps? > > The getline() function, even though is in POSIX.1-2008, is > not available on some platforms. Use strbuf_getline() for > portability. > > By the way, the remainder of the proposed log message talks about > the difference between getline() that keeps the terminating LF vs > strbuf_getline() that drops it. Would strbuf_getwholeline() be a > better alternative? I don't think it matters; I was just making sure Florian was aware of the difference (it will not appear in the commit message anyway), including the memory leak in the original code. ATB, Ramsay Jones