From: Phillip Wood Date: Tue, 08 Apr 2025 14:18:38 GMT Subject: Re: [PATCH v4 0/2] completion: fix bugs with slashes in remote names Message-ID: <5012fd2b-a68b-4267-aa4b-9dd04510986b@gmail.com> In-Reply-To: <17274df2746d304db876ebd82ad8d932@mandelberg.org> Hi David On 23/03/2025 21:04, David Mandelberg wrote: > Another minor change, as suggested by > https://lore.kernel.org/git/xmqqo6y3dzno.fsf@gitster.g/ > > I'm not sure what the expectations are around updating patches that are > scheduled to be merged to next but haven't been merged yet. If it's too > late, I'm happy with the previous v3, or I could send a separate patch. Unless a patch series has already been merged to next which in not the case here sending a new round of patches like this is the right thing to do. The range-diff (which you can add to your cover letter by passing "--range-diff" to "git format-patch") below looks good to me Sorry for the slow response and thanks for working on this Phillip 1: 5f4f1eb105 = 1: 58d036a048 completion: add helper to count path components 2: 28c0f80345 ! 2: 0383e1c608 completion: fix bugs with slashes in remote names @@ contrib/completion/git-completion.bash: __git_tags () + } + } + ' -+ __git for-each-ref --format='%(refname)' 'refs/remotes/**' | ++ __git for-each-ref --format='%(refname)' refs/remotes/ | + PFX="$pfx" SFX="$sfx" CUR_="$cur_" \ + IGNORE_CASE=${GIT_COMPLETION_IGNORE_CASE+1} \ + REMOTES="$(__git_remotes | sort -r)" awk "$awk_script" | > David Mandelberg (2): > completion: add helper to count path components > completion: fix bugs with slashes in remote names > > contrib/completion/git-completion.bash | 49 +++++- > t/t9902-completion.sh | 206 ++++++++++++++++++++++--- > 2 files changed, 226 insertions(+), 29 deletions(-) >