From: Phillip Wood Date: Fri, 09 Oct 2026 13:37:36 GMT Subject: Re: [PATCH] branch: let --delete-merged find squash merged branches Message-ID: <500a1b40-b877-4970-b279-f0a6fb42f810@gmail.com> In-Reply-To: Hi Harald On 08/10/2026 19:42, Harald Nordgren wrote: >> Even an efficient implementation is going to be a lot slower when it is >> trying to find branches that have been squashed, so I think we probably >> do want a way to turn it off. That's especially true in partial clones >> where we'll have to download a bunch of blobs to do the squash >> detection. So long as it isn't diabolically slow enabling it by default >> is probably fine. > > A bit slower (depends on how much!) could be worth it for improved > usability. This is not a command that users will run multiple times a > day. > > I would hope we could have it on by default and add a flag to turn it > off instead. That's my hope too > For partial or shallow clones, we should probably warn the user that > detection won't be able to search the full history, and offer them to > unshallow, etc. It's very reasonable that some parts are turned off, > when the user doesn't want to hold the complete repo. I've not really though much about shallow clones, but for partial clones I think it is perfectly reasonable to go and fetch the blobs we need to calculate the patch ids and warn in the documentation that it can be slow. Thanks Phillip