From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Mon, 16 Jul 2012 13:18:24 GMT
Subject: Re: [PATCH 1/2] refs: disallow ref components starting with hyphen
Message-ID: <500414A0.9080802@alum.mit.edu>
In-Reply-To: <1342440781-18816-2-git-send-email-mschub@elegosoft.com>

On 07/16/2012 02:13 PM, Michael Schubert wrote:
> Currently, we allow refname components to start with a hyphen. There's
> no good reason to do so and it troubles the parseopt infrastructure.
> Explicitly refuse refname components starting with a hyphen inside
> check_refname_component().

Your change to refs.c looks correct.  However, you should also update 
the documentation of the refname rules at the top of refs.c and also in

     Documentation/git-check-ref-format.txt

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/