From: Phillip Wood Date: Mon, 23 Oct 2023 15:43:32 GMT Subject: Re: [PATCH v3 0/3] rebase refactoring Message-ID: <4f8616d1-35f2-418d-9d28-b230ca45090d@gmail.com> In-Reply-To: On 20/10/2023 23:07, Junio C Hamano wrote: > Oswald Buddenhagen writes: > >> broken out of the bigger series, as the aggregation just unnecessarily holds it >> up. >> >> v3: removed "stray" footer. so more of a RESEND than an actual new version. >> >> Oswald Buddenhagen (3): >> rebase: simplify code related to imply_merge() >> rebase: handle --strategy via imply_merge() as well >> rebase: move parse_opt_keep_empty() down >> >> builtin/rebase.c | 44 ++++++++++++++------------------------------ >> 1 file changed, 14 insertions(+), 30 deletions(-) > > Looking quite straight-forward and I didn't see anythihng > potentially controversial. Yes they look good, thanks Oswald Best Wishes Phillip