From: Justin Tobler <jltobler@gmail.com>
Date: Wed, 27 Nov 2024 01:21:12 GMT
Subject: Re: [PATCH 4/5] fetch-pack: expose `fetch_pack_config_cb()`
Message-ID: <4f43efzkdocq4lohy2nkdebhdmlxt7adaui5h3pc4cvqb4gczu@mei2h3twif3z>
In-Reply-To: <Z0C1PxdltxDm8pyA@ArchLinux>

On 24/11/23 12:45AM, shejialuo wrote:
> On Thu, Nov 21, 2024 at 02:41:18PM -0600, Justin Tobler wrote:
> > During fetch-pack operations, git-index-pack(1) may be spawned and
> > perform fsck checks. The message severity of these checks is
> > configurable and propagated via appending it to the `--fsck-objects`
> > option.
> > 
> > With `fetch_pack_config_cb()`, fsck configuration gets populated to a
> > `fetch_pack_options`. Expose `fetch_pack_config_cb()`, to facilitate
> > formatted fsck message configuration generation. In a subsequent commit,
> > this is used to wire message configuration to `unbundle()` during bundle
> > fetches.
> > 
> 
> In my perspective, we may not separate [PATCH 4/5] and [PATCH 5/5].
> Should the reason why we want to expose `fetch_pack_config_cb` is that
> we need to propagate the fsck severity to `unbundle`? Without the
> information of the last patch, we cannot know any detail thing. So, they
> are highly relevant.

Thanks for the feedback. Due to other suggested changes, I've opted to
condense the third and fourth patch into one in the next version which I
think helps somewhat. I've also tried to update the commit messages to
provide additional context. Hopefully this helps :)

-Justin