From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Thu, 26 Jun 2025 16:15:13 GMT
Subject: Re: [PATCH] daemon: correctly handle soft accept() errors
Message-ID: <4e92bb11-1993-4cb2-be16-a972088f7cf3@app.fastmail.com>
In-Reply-To: <20250626161038.85966-1-carenas@gmail.com>

On Thu, Jun 26, 2025, at 18:10, Carlo Marcelo Arenas Belón wrote:
> Since df076bdbcc ([PATCH] GIT: Listen on IPv6 as well, if available.,
> 2005-07-23), the original error checking was included in an inner loop
> unchanged, where its effect was different.
>
> Instead of retrying, after a EINTR during accept() in the listening
> socket, it will advance to the next one and try with that instead,
> leaving the client waiting for another round.
>
> Make sure that the loop doesn't advance and while at it, make sure
> that any possible completed childs get reaped earlier. To avoid an

s/childs/children/

> unlilely busy loop, fallback to the old behaviour after a couple

unlilely?

> of attempts.
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>