From: Rubén Justo Date: Fri, 16 Jun 2023 23:14:45 GMT Subject: Re: tests: mark as passing with SANITIZE=leak Message-ID: <4e25776e-a490-091f-6f43-7f8f8413bf7b@gmail.com> In-Reply-To: <20230612040651.GK306352@coredump.intra.peff.net> On 12/6/23 6:06, Jeff King wrote: > On Sun, Jun 11, 2023 at 08:29:09PM +0200, Rubén Justo wrote: > >> Each of the commits (except 11/11) fixes a leak. They have no >> dependencies on each other. As a result, they can be reordered. > > Thanks for a pleasant read. I think each case is correct, though I left > a few minor comments. Some of them are things I think are worth > including in a re-roll. Others are things that we _could_ go further to > refactor for clarity, but I am OK if you want to stay focused on the > minimal leak-fixes. > > -Peff > Thank you for your prompt reviews, and sorry for my late responses.