From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: Mon, 31 May 2021 03:42:21 GMT
Subject: Re: [PATCH] refactor of git_setup_gettext method
Message-ID: <4df3a985-1359-cec9-c3db-fe069f24297d@gmail.com>
In-Reply-To: <pull.964.git.1622410962551.gitgitgadget@gmail.com>

Hi Dima, welcome to Git mailing list!

> diff --git a/gettext.c b/gettext.c
> index af2413b47e85..e75c7bfdb1a8 100644
> --- a/gettext.c
> +++ b/gettext.c
> @@ -109,17 +109,14 @@ void git_setup_gettext(void)
>   	if (!podir)
>   		podir = p = system_path(GIT_LOCALE_PATH);
>   
> -	if (!is_directory(podir)) {
> -		free(p);
> -		return;
> +	if (is_directory(podir)) {
> +		bindtextdomain("git", podir);
> +		setlocale(LC_MESSAGES, "");
> +		setlocale(LC_TIME, "");
> +		init_gettext_charset("git");
> +		textdomain("git");
>   	}
>   
> -	bindtextdomain("git", podir);
> -	setlocale(LC_MESSAGES, "");
> -	setlocale(LC_TIME, "");
> -	init_gettext_charset("git");
> -	textdomain("git");
> -

It seems like you move gettext initialization into if body, so the patch 
title should be better say "move gettext initialization to if body".

>   	free(p);
>   }
>   

Thanks for review.

-- 
An old man doll... just what I always wanted! - Clara