From: René Scharfe <l.s.r@web.de>
Date: Thu, 06 Apr 2017 20:20:35 GMT
Subject: Re: [PATCH v5 3/4] test-strcmp-offset: created test for strcmp_offset
Message-ID: <4da78dff-7caa-b560-8af9-f5a3dfc0bed2@web.de>
In-Reply-To: <20170405173809.3098-4-git@jeffhostetler.com>

Am 05.04.2017 um 19:38 schrieb git@jeffhostetler.com:
> diff --git a/t/helper/test-strcmp-offset.c b/t/helper/test-strcmp-offset.c
> new file mode 100644
> index 0000000..fe01318
> --- /dev/null
> +++ b/t/helper/test-strcmp-offset.c
> @@ -0,0 +1,64 @@
> +#include "cache.h"
> +
> +struct test_data {
> +	const char *s1;
> +	const char *s2;
> +	int first_change;
> +};
> +
> +static struct test_data data[] = {
> +	{ "abc", "abc", 0 },
> +	{ "abc", "def", 0 },
> +
> +	{ "abc", "abz", 2 },
> +
> +	{ "abc", "abcdef", 3 },
> +
> +	{ "abc\xF0zzz", "abc\xFFzzz", 3 },
> +
> +	{ NULL, NULL, 0 }
> +};
> +
> +int try_pair(const char *sa, const char *sb, int first_change)

This should be static, right?  Found with -Wmissing-prototypes.

> +{
> +	int failed = 0;
> +	int offset, r_exp, r_tst;
> +	int r_exp_sign, r_tst_sign;
> +
> +	/*
> +	 * Because differnt CRTs behave differently, only rely on signs

s/differnt/different/

René