From: Dirk Hörner <dirker@gmail.com>
Date: Mon, 07 Sep 2009 10:39:54 GMT
Subject: Re: [PATCH] Do not scramble password read from .cvspass
Message-ID: <4da546dc0909070339x5d78164flc4171882e8b028db@mail.gmail.com>
In-Reply-To: <7vvdjyn0j3.fsf@alter.siamese.dyndns.org>

Hi Junio,

On Fri, Sep 4, 2009 at 6:21 PM, Junio C Hamano<gitster@pobox.com> wrote:
> Dirk, does the patch look Ok to you?

The patch looks fine :-)

Ciao,
Dirk

>
>>  git-cvsimport.perl |    7 ++++---
>>  1 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/git-cvsimport.perl b/git-cvsimport.perl
>> index 593832d..c5cdcae 100755
>> --- a/git-cvsimport.perl
>> +++ b/git-cvsimport.perl
>> @@ -238,7 +238,10 @@ sub conn {
>>                 }
>>                 my $rr = ":pserver:$user\@$serv:$port$repo";
>>
>> -               unless ($pass) {
>> +               if ($pass) {
>> +                   $pass = $self->_scramble($pass);
>> +               } else
>> +               {
>>                         open(H,$ENV{'HOME'}."/.cvspass") and do {
>>                                 #
>> :pserver:cvs@mea.tmt.tele.fi:/cvsroot/zmailer Ah<Z
>>                                 while (<H>) {
>> @@ -253,8 +256,6 @@ sub conn {
>>                         };
>>                 }
>>
>> -               $pass = $self->_scramble($pass);
>> -
>>                 my ($s, $rep);
>>                 if ($proxyhost) {
>>
>> --
>> 1.6.4.2.253.g0b1fac
>