From: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Date: Mon, 25 Aug 2008 22:12:44 GMT
Subject: Re: [PATCH] Add a reference to gitk localbranc remote/branch in gittutorial
Message-ID: <4d8e3fd30808251512x126502bj5f154b58d7ae51a2@mail.gmail.com>
In-Reply-To: <7v63pog3rn.fsf@gitster.siamese.dyndns.org>

On 8/25/08, Junio C Hamano <gitster@pobox.com> wrote:
> Eric Raible <raible@gmail.com> writes:
>
>> Paolo Ciarrocchi <paolo.ciarrocchi <at> gmail.com> writes:
>>
>>> +Alice can also use gitk to browse that Bob did:
>>
>> s/that/what/ ?
>>
>>> +------------------------------------------------
>>> +alice$ gitk master origin/master
>>> +------------------------------------------------
>>
>> I think that you meant:
>>
>> alice$ gitk master..origin/master
>
>
> I'd suggest rewording the explanation to have Alice "compare what both of
> them did", not just "browse what Bob did".

yes, what i wrote was unclear. I managed to confuse myself too :-)

> And for that purpose, I think the original form used by Paolo's patch is
> the most appropriate here in an early part of the tutorial, as it teaches
> how to view full histories leading to the tips of these two branches.

well, it might be a good idea to mention both.

do you think we should add a note about git log --graph as well?

> Earlier in the tutorial sequence we teach "gitk" without any parameter to
> view the history of the current branch, and here the user learns one new
> thing, to view more than just the current branch.

i think we should use the nice gitk output in other sections of the
document as well, i'll send some more patches.

> Limiting the output with "..origin/master" (or "...origin/master") can be
> taught after demonstrating this most basic form.


what wording would you use to clearly explain the difference between
..origin/master and ...origin/master ?

anyway, thanks for the commentr. I'll send a new patch in 24 hours.

ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/