From: Phillip Wood Date: Thu, 16 Jul 2026 09:37:22 GMT Subject: Re: [PATCH] rebase: mention --abort alongside --continue Message-ID: <4d150f21-46ea-4bf7-b516-c1763c152b34@gmail.com> In-Reply-To: Hi Harald On 16/07/2026 07:02, Harald Nordgren wrote: > I'll revive this discussion because the 'git rebase --keep-base -x' > case still bothers me. > > When getting stuck in the middle of an operation, it just makes sense > to offer a way forward and a way back, why be more obtuse than we need > to? I'm still not clear why you'd want to abort after a failed exec. In the example you gave earlier in the thread where the exec command was trying to run a command that did not exist isn't the solution to edit the todo list to fix that, or if just this exec command is wrong, continue the rebase? In the latter case it would be useful is to teach "git rebase --skip" to skip a failed exec command that has been rescheduled by "--reschedule-failed-exec" and provide a hint to the user that they can skip the rescheduled command. We could potentially add a hint to suggest that if the failure was due to a bad command then the user should edit the todo list. To me aborting a rebase because an exec command failed is almost never a sensible route forward and we should not be encouraging users to abort after a failed test - surely the sensible thing to do in that case is fix the problem with "git commit --amend" and continue the rebase. Thanks Phillip