From: Fredrik Kuivinen <frekui@gmail.com>
Date: Sun, 07 Jan 2007 12:56:59 GMT
Subject: Re: [PATCH] git-reset --hard: use quotes when we tell the user what HEAD was reset to
Message-ID: <4c8ef70701070456k2f0585f4ga6c35bd77c939c59@mail.gmail.com>
In-Reply-To: <7v8xgg553u.fsf@assigned-by-dhcp.cox.net>

On 1/6/07, Junio C Hamano <junkio@cox.net> wrote:
> Fredrik Kuivinen <freku045@student.liu.se> writes:
>
> > Idea and motivating example from Andy Whitcroft:
> >
> >     apw@pinky$ git checkout -b bar master
> >     apw@pinky$ git reset --hard ac9c1108d8915f0937795e354ad72c4ae6890a3f
> >     HEAD is now at ac9c110... git-fetch: remove .keep file at the end.
> >
> >     Huh, fetch?  Remove what .keep file?  Did I do a fetch?  What?
> >
> >     I think we need to delimit the name better, probabally we need to quote
> >     it.  Perhaps something like:
> >
> >     HEAD is now at ac9c110: "git-fetch: remove .keep file at the end".
>
> I've also considered something along that line, but:
>
>  (1) I think this 'confusion' is only because you are futzing
>      with a project that deals with git-fetch and friends and
>      not a general problem.
>
>  (2) With "HEAD is now at xxxxx..."  prefix, even two characters
>      are precious to fit the title of the commit on a single
>      line.
>
> With these in mind, do you still want to do this?

I don't think the second point is much of an issue. Is it really that
irritating to
read a word-wrapped line of text? I agree with the first point though, in most
cases it will not be a problem in other projects.

I still think it is worth doing it, but it certainly isn't super
important. Feel free
to drop the patch if you want to.

- Fredrik