From: Johannes Sixt <j6t@kdbg.org>
Date: Wed, 19 Apr 2017 06:00:49 GMT
Subject: Re: [PATCH v5 11/11] run-command: block signals between fork and execve
Message-ID: <4c2f91fd-c9bd-cfe0-4e2d-3f1669410579@kdbg.org>
In-Reply-To: <20170418231805.61835-12-bmwill@google.com>

Am 19.04.2017 um 01:18 schrieb Brandon Williams:
> @@ -400,6 +404,53 @@ static char **prep_childenv(const char *const *deltaenv)
>  }
>  #endif
>

Does this #endif in this hunk context belong to an #ifndef 
GIT_WINDOWS_NATIVE? If so, I wonder why these new functions are outside 
these brackets? An oversight?

> +struct atfork_state {
> +#ifndef NO_PTHREADS
> +	int cs;
> +#endif
> +	sigset_t old;
> +};
...

-- Hannes