From: Derrick Stolee Date: Wed, 08 Sep 2021 11:44:26 GMT Subject: Re: [PATCH v10 0/3] maintenance: add support for systemd timers on Linux Message-ID: <4c0c1fd4-f3f4-5e3a-abd2-0350c18b18b7@gmail.com> In-Reply-To: <28e0f22a-e9be-bb18-df0f-4d95cb6d5145@gmail.com> On 9/7/2021 12:48 PM, Derrick Stolee wrote: > On 9/4/2021 4:54 PM, Lénaïc Huard wrote: >> Hello, >> >> Please find hereafter my updated patchset to add support for systemd >> timers on Linux for the `git maintenance start` command. >> >> The only changes compared to the previous version are fixes for the >> two typos in a comment that Ramsay Jones pointed out [1] >> >> [1] https://lore.kernel.org/git/51246c10-fe0b-b8e5-cdc3-54bdc6c8054e@ramsayjones.plus.com/ > > The changes in the most recent two versions look good to me. I recently tested the 'seen' branch for an unrelated reason, but found that the t7900-maintenance.sh test failed for me. It was during test 34, 'start and stop Linux/systemd maintenance' with the following issue: + systemd-analyze verify systemd/user/git-maintenance@.service Failed to create /user.slice/user-1000.slice/session-44.scope/init.scope control group: Permission denied Failed to initialize manager: Permission denied Now, this test has the prereq SYSTEMD_ANALYZE, but for some reason this later command fails for permission issues. I'm running Ubuntu, if that helps. Thanks, -Stolee