From: Tuncer Ayaz Date: Wed, 19 Nov 2008 23:00:14 GMT Subject: Re: [PATCH] Retain multiple -q/-v occurrences in git pull Message-ID: <4ac8254d0811191500q4e06558aj79926ab9d2401e7f@mail.gmail.com> In-Reply-To: <4ac8254d0811191458r2a205be3w4a412553edc9b07f@mail.gmail.com> [re-sent due to propagated wrong Junio address. sorry.] On Wed, Nov 19, 2008 at 12:46 PM, Constantine Plotnikov wrote: > On Tue, Nov 18, 2008 at 1:09 AM, Tuncer Ayaz wrote: >> To support counting -q/-v options in git pull retain >> them by concatenating. >> > [rest of message cut] > > By the way, there is yet another way to invoke git fetch. It is "git > remote update". Possibly it should support "-v" and "-q" options for > consistency as well. Yes, we could add -q to builtin-remote and also make sure that it passes the already existing -v and maybe a yet-to-be-added -q to the fetch command. I want to be first sure what the overall strategy regarding -q/-v is. Right now we have some code which uses OPT__VERBOSE/OPT__QUIET and some new code which uses the newly-added OPT__VERBOSITY. These are the options I can see: 1) Use the old and new macros and decide in each module which one to use 2) Get rid off OPT__VERBOSE and OPT__QUIET and use OPT__VERBOSITY only 3) Think about new ways to handle all of this. Possibly some new print_* macros? Any opinions?