From: Tuncer Ayaz Date: Mon, 17 Nov 2008 10:55:59 GMT Subject: Re: [PATCH] Teach/Fix pull/fetch -q/-v options Message-ID: <4ac8254d0811170255t4706f8efu5d60f4f05cbdab4@mail.gmail.com> In-Reply-To: <7vy6ziy69h.fsf@gitster.siamese.dyndns.org> On Mon, Nov 17, 2008 at 11:51 AM, Junio C Hamano wrote: > "Tuncer Ayaz" writes: > >> I think you need to have something like the following applied on top of >> what's in pu to be able to use "pull -v -v -v" and be able to count the >> occurrences via parse-options.c. What do you think? > > Makes sense, except that as a futureproofing we may be better off doing > the same for -q as well. What's funny is that my original patch to git-pull.sh had both :). >> --- git-pull.sh 2008-11-17 11:32:19.000000000 +0100 >> +++ git-pull.sh.b 2008-11-17 11:33:03.000000000 +0100 >> @@ -26,7 +26,7 @@ >> -q|--quiet) >> verbosity=-q ;; >> -v|--verbose) >> - verbosity=-v ;; >> + verbosity="$verbosity -v" ;; >> -n|--no-stat|--no-summary) >> no_stat=-n ;; >> --stat|--summary) >> >> Signed-off-by: Tuncer Ayaz >